-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache ViewManagerDelegate on ViewManagers #48550
Open
mdvacca
wants to merge
3
commits into
facebook:main
Choose a base branch
from
mdvacca:export-D67957883
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+137
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Jan 9, 2025
This pull request was exported from Phabricator. Differential Revision: D67957883 |
mdvacca
force-pushed
the
export-D67957883
branch
from
January 9, 2025 21:40
80193ed
to
20c96e8
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 9, 2025
Summary: Cache ViewManagerDelegate on ViewManagers changelog: [internal] internal Differential Revision: D67957883
This pull request was exported from Phabricator. Differential Revision: D67957883 |
mdvacca
force-pushed
the
export-D67957883
branch
from
January 10, 2025 19:18
20c96e8
to
b46c42d
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 10, 2025
Summary: Cache ViewManagerDelegate on ViewManagers changelog: [internal] internal Differential Revision: D67957883
This pull request was exported from Phabricator. Differential Revision: D67957883 |
mdvacca
force-pushed
the
export-D67957883
branch
from
January 10, 2025 19:27
b46c42d
to
8a8dcd0
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 10, 2025
Summary: Cache ViewManagerDelegate on ViewManagers changelog: [internal] internal Differential Revision: D67957883
This pull request was exported from Phabricator. Differential Revision: D67957883 |
Summary: In this diff I'm introducing the new public API ViewManagerInterface, this will be used in the next diffs of the stack to be implemented by all viewManagerInterfaces that are code-gen when using the new architecture changelog: [Android][Changed] Introduce new public API ViewManagerInterface Reviewed By: javache Differential Revision: D67957886
facebook#48549) Summary: Refactor ViewManager codegen to use new ViewManagerInterface changelog: [internal] internal Reviewed By: javache Differential Revision: D67957884
Summary: Cache ViewManagerDelegate on ViewManagers changelog: [internal] internal Differential Revision: D67957883
mdvacca
force-pushed
the
export-D67957883
branch
from
January 10, 2025 19:51
8a8dcd0
to
9750f8f
Compare
This pull request was exported from Phabricator. Differential Revision: D67957883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cache ViewManagerDelegate on ViewManagers
changelog: [internal] internal
Differential Revision: D67957883